DataNucleus JIRA is now in read-only mode. Raise any new issues in GitHub against the plugin that it applies to. DataNucleus JIRA will remain for the foreseeable future but will eventually be discontinued
Issue Details (XML | Word | Printable)

Key: NUCCORE-1209
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Unassigned
Reporter: Kaarel Kann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
DataNucleus Core

Constructor cache in IdentityManagerImpl

Created: 20/May/14 10:21 AM   Updated: 21/May/14 05:09 PM   Resolved: 20/May/14 11:23 AM
Component/s: None
Affects Version/s: 4.0.0.m3
Fix Version/s: 4.0.0.m4

File Attachments: 1. Zip Archive perf-test-h2.zip (6 kB)


Severity: Development


 Description  « Hide
Finding constructor for Identity class is a bit expensive and can be optimized by caching them.
It can save up to 5% cpu.


Kaarel Kann added a comment - 20/May/14 10:39 AM
Attached performance test.

Results
4.0.0-m3: 37411ms
NUCCORE-1209: 35164ms

Pull request filed:
https://github.com/datanucleus/datanucleus-core/pull/3

Kaarel Kann made changes - 20/May/14 10:39 AM
Field Original Value New Value
Attachment perf-test-h2.zip [ 12069 ]
Andy Jefferson added a comment - 20/May/14 11:23 AM
GitHub master has an adapted form of this patch. Thx

Please follow the coding standards at http://www.datanucleus.org/documentation/development/coding_standards.html and then I can just apply the patch direct for any future.

Andy Jefferson made changes - 20/May/14 11:23 AM
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 4.0.0.m4 [ 12184 ]
Resolution Fixed [ 1 ]
Andy Jefferson made changes - 21/May/14 05:09 PM
Status Resolved [ 5 ] Closed [ 6 ]