DataNucleus JIRA is now in read-only mode. Raise any new issues in GitHub against the plugin that it applies to. DataNucleus JIRA will remain for the foreseeable future but will eventually be discontinued
Issue Details (XML | Word | Printable)

Key: NUCCORE-1212
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Andy Jefferson
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.
DataNucleus Core

Change Localisation sub-system to allow each plugin to register its bundle, and specify language/errorCodes via System properties

Created: 22/May/14 05:11 PM   Updated: 27/May/14 08:18 PM   Resolved: 23/May/14 11:24 AM
Component/s: Code Structure
Affects Version/s: None
Fix Version/s: 4.0.0.m4

 Description  « Hide
Specifying language/errorCodes flags via persistence properties makes no sense since Localiser is static, and we can't have different Localisation for each PMF, only per JVM.

Also we have LOCALISER dotted through the code and would make more sense just to have each plugin register the ResourceBundle it provides, and then on the msg calls the msgKey should be enough to define the message (and it finds it in whichever ResourceBundles are available/registered).

Andy Jefferson added a comment - 23/May/14 11:24 AM
GitHub makes this change, with plugin code now responsible for register their bundle if they have one, and call Localiser.msg (static) so no need to get an instance of Localiser.

Andy Jefferson made changes - 23/May/14 11:24 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 4.0.0.m4 [ 12184 ]
Resolution Fixed [ 1 ]
Andy Jefferson made changes - 27/May/14 08:18 PM
Status Resolved [ 5 ] Closed [ 6 ]