Issue Details (XML | Word | Printable)

Key: NUCCORE-373
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Stefan Seelmann
Reporter: Stefan Seelmann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
DataNucleus Core

Embedded collections elements are not updated

Created: 27/Aug/09 10:49 PM   Updated: 11/Sep/09 08:40 AM   Resolved: 28/Aug/09 01:08 PM
Component/s: Persistence
Affects Version/s: 2.0.0.m1
Fix Version/s: 2.0.0.m2

File Attachments: 1. Text File NUCCORE-373.patch (21 kB)


Datastore: LDAP


 Description  « Hide
Embedded collection elements are not updated for data stores (like store-ldap) that use non-backed collections from org.datanucleus.sco.simple

The reason is that the SCOCollection.updateEmbeddedElement(Object element, int fieldNumber, Object value) isn't implemented for these simple collections (and maps). An possible fix is to call makeDirty() in all these methods and also to call makeDirty() for all embedded owners. I'll attach a patch for review.


Sort Order: Ascending order - Click to sort in descending order
Andy Jefferson added a comment - 28/Aug/09 09:11 AM
No obvious problem with the patch; maybe remove the comment in the sco classes "// Embedded not supported so thing to do" since you are marking the owner field as dirty now.

Stefan Seelmann added a comment - 28/Aug/09 01:08 PM
Fixed in trunk