Issue Details (XML | Word | Printable)

Key: NUCCORE-547
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Peter Dettman
Reporter: Peter Dettman
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
DataNucleus Core

Improve type safety for queued operations on SCO collections

Created: 26/Jun/10 10:56 AM   Updated: 20/Oct/10 09:29 AM   Resolved: 26/Jun/10 03:01 PM
Component/s: Code Structure
Affects Version/s: 2.1.1
Fix Version/s: 2.2.0.m1


 Description  « Hide
1. The operation classes in package org.datanucleus.store.types.sco.queued currently need to cast the provided store during perform().

2. ClearOperation/RemoveOperation are doing double duty for methods in Collection/Map that happen to share the same name, requiring an instanceof check during perform().

3. The collection classes in org.datanucleus.store.types.sco.backed add operations to an OperationQueue without any type constraints to guard against inappropriate operations for the backing store.


Peter Dettman made changes - 26/Jun/10 12:22 PM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.1.2 [ 11012 ]
Resolution Fixed [ 1 ]
Andy Jefferson added a comment - 26/Jun/10 12:29 PM
SVN trunk is now for 2.2.x so will be in 2.2.0.m1. Apply to branches/2.1 if needed on 2.1

Andy Jefferson made changes - 26/Jun/10 12:29 PM
Fix Version/s 2.2.0.m1 [ 10999 ]
Fix Version/s 2.1.2 [ 11012 ]
Andy Jefferson added a comment - 26/Jun/10 12:52 PM
Hi Peter, can you also please update project "store.types.google.collections" since it will no longer build. I've branched off a "branches/2.1" so now trunk of that project is for 2.2

Andy Jefferson made changes - 26/Jun/10 12:52 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Andy Jefferson added a comment - 26/Jun/10 12:58 PM
Actually I've just attempted to match your changes in that project; please check it is what you intended and then close this

Peter Dettman added a comment - 26/Jun/10 03:01 PM
Thanks for catching that; I didn't have the google collections project in my workspace.
I made a couple more changes to the backed Multiset in line with the changes in core.

Peter Dettman made changes - 26/Jun/10 03:01 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Andy Jefferson made changes - 20/Oct/10 09:29 AM
Status Resolved [ 5 ] Closed [ 6 ]