Issue Details (XML | Word | Printable)

Key: NUCCORE-924
Type: Improvement Improvement
Status: Closed Closed
Resolution: Won't Fix
Priority: Minor Minor
Assignee: Unassigned
Reporter: Michael Brown
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
DataNucleus Core

Remove working directory prefix from file paths before passing as arguments on command line to SchemaTool and Enhancer. This reduces chance of exceeding maximum argument length.

Created: 09/Sep/09 10:52 AM   Updated: 24/Apr/14 10:48 AM   Resolved: 24/Apr/14 10:45 AM
Component/s: Enhancer
Affects Version/s: None
Fix Version/s: None

File Attachments: 1. Text File pathpatch.patch (6 kB)

Environment: Win XP


 Description  « Hide
The ANT EnhancerTask and SchemaToolTask are building command lines that are too long for Windows to handle. This causes build failures.
To improve this I have patched DN to strip the working directory prefix from any file paths before building a command line to execute the enhancer/schema.
In a Windows environment, where paths are typically quite long, this makes a big difference.

In SchemaToolTask I have added methods getDir/setDir to capture the working directory before the command excutes.
In both EnhancerTask and SchemaToolTask I have modified the construction of the file arguments, to strip the working directory from paths before they are added. This occurs within the execute method.

I feel that this is a generally useful improvement, and so submit for inclusion to SVN.

Michael Brown added a comment - 09/Sep/09 10:53 AM
Patch for changes as noted.

Michael Brown made changes - 09/Sep/09 10:53 AM
Field Original Value New Value
Attachment pathpatch.patch [ 11013 ]
Andy Jefferson made changes - 05/Oct/12 05:06 PM
Project DataNucleus Enhancer (ARCHIVED) [ 10165 ] DataNucleus Core [ 10143 ]
Key NUCENHANCER-44 NUCCORE-924
Affects Version/s 2.0.0.m1 [ 10660 ]
Component/s Enhancer [ 10350 ]
Andy Jefferson added a comment - 16/Jul/13 12:06 PM
any interest in updating this patch to current codebase?

Andy Jefferson added a comment - 24/Apr/14 10:45 AM
An issue was fixed in 4.0.0-m2 to allow all classes/files to be written to a file and that file read in. That means this issue is unimportant

Andy Jefferson made changes - 24/Apr/14 10:45 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Won't Fix [ 2 ]
Andy Jefferson made changes - 24/Apr/14 10:48 AM
Status Resolved [ 5 ] Closed [ 6 ]