Issue Details (XML | Word | Printable)

Key: NUCJPA-188
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Andy Jefferson
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
DataNucleus API JPA

Missing space after filter in criteria generated query string

Created: 25/Oct/12 07:52 AM   Updated: 26/Oct/12 05:39 PM   Resolved: 25/Oct/12 07:54 AM
Component/s: API
Affects Version/s: 3.0.11, 3.1.0.release
Fix Version/s: 3.1.3, 3.2.0.m1


Sort Order: Ascending order - Click to sort in descending order
Andy Jefferson added a comment - 25/Oct/12 07:54 AM
SVN trunk and branches/3.1 have this

Marcel Overdijk added a comment - 25/Oct/12 03:50 PM
I used the latest SNAPSHOT (25-Oct-2012 13:08) and can verify this fix was in as I see spaces now.

However updating to 3.1.3-SNAPSHOT (the other DataNucleus deps I'm using are still 3.1.1) breaks my code which was working before:

15:39:27,836 DEBUG [DataNucleus.Query] - JPQL Single-String with "SELECT DN_THIS FROM org.mycomp.domain.User DN_THIS WHERE (DN_THIS.username = ?-1) ORDER BY"
15:39:27,839 ERROR [org.mycomp.service.userdetails.UserDetailsService] - Error loading user: admin
org.springframework.dao.InvalidDataAccessApiUsageException: JPQL Query has been specified with keyword "ORDER BY" but has no value specified. Should have "<ordering>" specified after "ORDER BY".; nested exception is java.lang.IllegalArgumentException: JPQL Query has been specified with keyword "ORDER BY" but has no value specified. Should have "<ordering>" specified after "ORDER BY".

Is there maybe a regression?

Andy Jefferson added a comment - 25/Oct/12 04:18 PM
DN unit tests for JPA/JDO (all public, easily verified) pass and JPA1/JDO3 TCKs (JDO TCK is public) pass for 3.1 and 3.2 codebases. So no, no regression in any supported behaviour.

Marcel Overdijk added a comment - 25/Oct/12 08:40 PM
OK, let's further discuss this in the forum: http://www.datanucleus.org/servlet/forum/viewthread_thread,7320