Issue Details (XML | Word | Printable)

Key: NUCJPA-259
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Oliver Gierke
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
DataNucleus API JPA

FromImpl must not return null for getJoins()

Created: 16/Dec/13 10:49 AM   Updated: 22/Dec/13 04:19 PM   Resolved: 16/Dec/13 11:04 AM
Component/s: None
Affects Version/s: 3.3.4
Fix Version/s: 3.3.6

Environment: http://stackoverflow.com/questions/20587980/spring-data-repository-throws-npe-on-creation


 Description  « Hide
If {{getJoins()}} is called on {{FromImpl}} without a join being present, you're not getting back an empty {{Set}} as one would expect, but {{null}}. This causes {{NullPointerExceptions}} in case you're directly iterating over the result (e.g. in a foreach-loop). Generally speaking, methods with a collection return type should never return null but empty collections.

Sort Order: Ascending order - Click to sort in descending order
Andy Jefferson added a comment - 16/Dec/13 11:04 AM
Fixes in GitHub master for getJoins() and also getFetches()

Oliver Gierke added a comment - 16/Dec/13 11:32 AM
Wow, that was fast! :) Any estimated release date for 3.3.6, so that I can report back on StackOverflow?

Andy Jefferson added a comment - 16/Dec/13 11:47 AM
No release date yet, but SO user could just grab it from DN nightly builds at
http://www.datanucleus.org/downloads/maven2-nightly/org/datanucleus/