Issue Details (XML | Word | Printable)

Key: NUCJPA-31
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Andy Jefferson
Reporter: Max Ross (App Engine)
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
DataNucleus API JPA

JPAAnnotationReader ignores 'optional' attribute of ManyToOne annotation

Created: 24/Jul/09 06:28 AM   Updated: 11/Sep/09 08:42 AM   Resolved: 20/Aug/09 10:23 AM
Component/s: None
Affects Version/s: 1.1.5
Fix Version/s: 2.0.0.m2

Datastore: Other


 Description  « Hide
http://datanucleus.svn.sourceforge.net/viewvc/datanucleus/platform/jpa/branches/1.1/src/java/org/datanucleus/jpa/metadata/JPAAnnotationReader.java?revision=6540&view=markup
Line 1435 and below.
JPAAnnotationReader isn't processing the 'optional' annotation. Right now App Engine always throws an exception if a ManyToOne is null but we'd rather only throw the exception if it's null and optional is false. Here's the App Engine bug that was filed:
http://code.google.com/p/googleappengine/issues/detail?id=1456

Sort Order: Ascending order - Click to sort in descending order
Andy Jefferson added a comment - 24/Jul/09 01:34 PM
That DN doesn't support "optional" is one issue, but at the end of the day GAE/J should be using the AbstractMemberMetaData "nullValue" flag to decide what action to take, since that is the mechanism ... for JDO or JPA

Max Ross (App Engine) added a comment - 24/Jul/09 05:29 PM
Agreed. GAE/J doesn't respect the null constraints at all right now.

http://code.google.com/p/datanucleus-appengine/issues/detail?id=54

Andy Jefferson added a comment - 20/Aug/09 10:23 AM
SVN trunk works with this.