Issue Details (XML | Word | Printable)

Key: NUCRDBMS-537
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Daniel Baldes
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
DataNucleus Store RDBMS

ConnectionPool properties not marked as datastore properties

Created: 29/Jun/11 02:47 PM   Updated: 01/Aug/11 05:13 PM   Resolved: 29/Jun/11 08:37 PM
Component/s: None
Affects Version/s: 3.0.0.m5
Fix Version/s: 3.0.0.m6

File Attachments: 1. Text File datastore-pluginxml.patch (3 kB)



 Description  « Hide
Connection pool properties such as datanucleus.connectionPool.maxPoolSize are not marked 'datastore="true"' in datanucleus-store-rdbms' plugin.xml, therefore they do not end up in the StoreManager configuration and in turn they are not recognized by BoneCPDataSourceFactory, for instance.

Therefore, connection pool properties are eventually ignored.

I don't know whether the bug is that these properties are not marked with datastore="true", or if BoneCPDataSourceFactory should access those properties in another way, though.

Daniel Baldes added a comment - 29/Jun/11 02:49 PM
The attached patch for datanucleus-rdbm-store's trunk adds datastore="true" to all connection pool properties of the org.datanucleus.persistence_properties extension point. This works for me.

Daniel Baldes made changes - 29/Jun/11 02:49 PM
Field Original Value New Value
Attachment datastore-pluginxml.patch [ 11473 ]
Andy Jefferson added a comment - 29/Jun/11 08:37 PM
Implementing the getXXXProperty methods performs the same yet also handles any other props accidentally left on the PersistenceConfiguration; that and your patch in SVN trunk. Thx

Andy Jefferson made changes - 29/Jun/11 08:37 PM
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 3.0.0.m6 [ 11280 ]
Resolution Fixed [ 1 ]
Andy Jefferson made changes - 01/Aug/11 05:13 PM
Status Resolved [ 5 ] Closed [ 6 ]